opt-in warning attribute not valid for union case with fields #18532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
changed the title
❗ Release notes required
|
edgarfgp
commented
May 5, 2025
edgarfgp
commented
May 5, 2025
…arp into attr-targets-opt-in-warning
T-Gro
reviewed
May 21, 2025
T-Gro
reviewed
May 22, 2025
…arp into attr-targets-opt-in-warning
T-Gro
approved these changes
May 28, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
|
Thanks @edgarfgp for your persistance in getting this trough. With the PR, the feature is in a shape that will not risk breaking compatibility for existing code, even if it was/is semantically wrong when it comes to attribute usage. |
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #18492
Related: #18298
Checklist